From ca1cbd723a461db0cc33c6aca01edbc233915814 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matej=20Glasn=C3=A1k?= Date: Fri, 3 Mar 2023 10:36:11 +0100 Subject: [PATCH 1/2] [Refactoring] --- app/src/plugins/app/_config/App.vue | 53 ++++---- .../app/_layout/app/_components/a-header.vue | 4 +- .../login/_components/a-login-form.vue | 2 +- .../_components/a-seach-result-task.vue | 12 +- app/src/plugins/lib@search/search/search.vue | 2 +- .../tm@dashboard/_components/z-timeline.vue | 14 +-- .../tm@dashboard/projects/projects.vue | 2 +- .../tm@modal/blocker/z-blocker-modal.vue | 3 +- .../master-task/_components/a-tasks-table.vue | 49 ++++---- .../master-task/_mixins/selects.mixin.ts | 4 +- .../z-delete-master-task-modal.vue | 2 +- .../master-task/z-master-task-modal.vue | 15 ++- .../_components/a-mastertask-name.vue | 2 +- .../_components/a-task-spent-time.vue | 24 ++-- .../_components/a-task-timeblocks.vue | 18 +-- .../task/_components/z-task-readonly-info.vue | 22 ++-- .../tm@modal/task/z-delete-task-modal.vue | 16 +-- .../tm@modal/task/z-task-add-time-modal.vue | 1 + .../plugins/tm@modal/task/z-task-modal.vue | 117 +++++++++--------- .../tm@modal/team/z-delete-team-modal.vue | 2 +- .../plugins/tm@modal/team/z-team-modal.vue | 3 +- .../_components/a-ongoing-table.vue | 26 ++-- .../tasks-ongoing/tasks-ongoing.vue | 2 +- .../_components/a-unscheduled-table.vue | 24 ++-- .../tasks-unscheduled/tasks-unscheduled.vue | 2 +- 25 files changed, 215 insertions(+), 206 deletions(-) diff --git a/app/src/plugins/app/_config/App.vue b/app/src/plugins/app/_config/App.vue index 8fd52b2..b6f512b 100644 --- a/app/src/plugins/app/_config/App.vue +++ b/app/src/plugins/app/_config/App.vue @@ -9,7 +9,7 @@ - + @@ -44,35 +44,35 @@ export default { mounted() { this.$events.on('show-delete-team-modal', ({team}) => { - this.$refs['z-delete-team-modal'].showModal(team) + this.$refs['z-delete-team-modal'].showModal({ team }) }) - this.$events.on('show-team-modal', ({team}) => { - this.$refs['z-team-modal'].showModal(team) + this.$events.on('show-team-modal', ({ team }) => { + this.$refs['z-team-modal'].showModal({ team }) }) - this.$events.on('show-delete-task-modal', ({task}) => { - this.$refs['z-delete-task-modal'].showModal(task) + this.$events.on('show-delete-task-modal', ({subtask}) => { + this.$refs['z-delete-task-modal'].showModal({subtask}) }) this.$events.on('show-delete-master-task-modal', ({mastertask}) => { - this.$refs['z-delete-master-task-modal'].showModal(mastertask) + this.$refs['z-delete-master-task-modal'].showModal({mastertask}) }) - this.$events.on('show-task-modal', ({task, editMode, mastertask}) => { - if(task && task.id) { - const id = task.id - this.$router.push({ query: { 'task': id }}) + this.$events.on('show-subtask-modal', ({subtask, editMode, mastertask}) => { + if(subtask && subtask.id) { + const id = subtask.id + this.$router.push({ query: { 'subtask': id }}) } - this.$refs['z-task-modal'].showModal(task, editMode, mastertask) + this.$refs['z-task-modal'].showModal({subtask, editMode, mastertask}) }) - this.$events.on('show-master-task-modal', ({ mastertask, editMode }) => { + this.$events.on('show-mastertask-modal', ({ mastertask, editMode }) => { if (mastertask && mastertask.id) { const id = mastertask.id - this.$router.push({ query: { 'master-task': id } }) + this.$router.push({ query: { 'mastertask': id } }) } - this.$refs['z-master-task-modal'].showModal(mastertask, editMode) + this.$refs['z-master-task-modal'].showModal({mastertask, editMode}) }) this.$events.on('show-complete-task-modal', ({ subtask }) => { @@ -98,6 +98,8 @@ export default { this.$events.on('on-mastertask-deleted', () => { this.$store.dispatch('tm/reloadMastertasks') }) + + this._showModalsAfterInicialization() }, methods: { @@ -106,7 +108,7 @@ export default { }, onTaskDeleted(task) { - this.$events.emit('on-task-deleted', task) + this.$events.emit('on-subtask-deleted', task) }, onTaskEdited(task) { @@ -119,14 +121,19 @@ export default { onMasterTaskEdited(mastertask){ this.$events.emit('on-mastertask-edited', mastertask) - } - }, + }, - watch: { - '$route'() { - // if (this.$route.query['master-task']) { - // this.$events.emit('show-master-task-modal', { mastertask: { id: this.$route.query['master-task'] }, editMode: false }) - // } + _showModalsAfterInicialization(repeat = 0) { + setTimeout(() => { + if (repeat > 50) + return this.$router.push({name: this.$route.name}) + else if (!this.$store.getters['tm/isInitialized']) + return this._showModalsAfterInicialization(repeat + 1) + else if (this.$route.query['mastertask']) + return this.$events.emit('show-mastertask-modal', { mastertask: { id: this.$route.query['mastertask'] }, editMode: false }) + else if (this.$route.query['subtask']) + return this.$events.emit('show-subtask-modal', { subtask: { id: this.$route.query['subtask'] }, editMode: false }) + }, 300) } } } diff --git a/app/src/plugins/app/_layout/app/_components/a-header.vue b/app/src/plugins/app/_layout/app/_components/a-header.vue index 7bc2742..1e62b1b 100644 --- a/app/src/plugins/app/_layout/app/_components/a-header.vue +++ b/app/src/plugins/app/_layout/app/_components/a-header.vue @@ -79,11 +79,11 @@ export default { }, createMasterTask() { - this.$events.emit('show-master-task-modal', {}) + this.$events.emit('show-mastertask-modal', {}) }, createTask() { - this.$events.emit('show-task-modal', {}) + this.$events.emit('show-subtask-modal', {}) }, createTeam() { diff --git a/app/src/plugins/lib@auth/login/_components/a-login-form.vue b/app/src/plugins/lib@auth/login/_components/a-login-form.vue index 3914ff5..41a48d4 100644 --- a/app/src/plugins/lib@auth/login/_components/a-login-form.vue +++ b/app/src/plugins/lib@auth/login/_components/a-login-form.vue @@ -24,7 +24,7 @@ export default { v$: useVuelidate(), form: {}, // form: { - // email: 'zachariah.vonrueden@jandl.sk', + // email: 'jan.fajnor@jandl.sk', // password: 'testpassword' // }, showPassword: false diff --git a/app/src/plugins/lib@search/search/_components/a-seach-result-task.vue b/app/src/plugins/lib@search/search/_components/a-seach-result-task.vue index ebc49ba..be23a4d 100644 --- a/app/src/plugins/lib@search/search/_components/a-seach-result-task.vue +++ b/app/src/plugins/lib@search/search/_components/a-seach-result-task.vue @@ -3,13 +3,13 @@

Tasks

- - {{ task.project_code }} - {{ task.title }} + + {{ subtask.project_code }} + {{ subtask.title }} -

{{ task.user.name + task.user.surname }}

+

{{ subtask.user.name + subtask.user.surname }}

- {{ task.user.name.charAt(0) }} + {{ subtask.user.name.charAt(0) }}

@@ -29,7 +29,7 @@ export default { props: { - tasks: { + subtasks: { type: Array, required: true } diff --git a/app/src/plugins/lib@search/search/search.vue b/app/src/plugins/lib@search/search/search.vue index 9d71c2e..73e18d4 100644 --- a/app/src/plugins/lib@search/search/search.vue +++ b/app/src/plugins/lib@search/search/search.vue @@ -1,7 +1,7 @@ diff --git a/app/src/plugins/tm@dashboard/_components/z-timeline.vue b/app/src/plugins/tm@dashboard/_components/z-timeline.vue index f220716..450d82e 100644 --- a/app/src/plugins/tm@dashboard/_components/z-timeline.vue +++ b/app/src/plugins/tm@dashboard/_components/z-timeline.vue @@ -195,10 +195,10 @@ export default { return event.end.getTime() - event.start.getTime() }, - taskClicked(task) { - if (task.nonWorking) return + taskClicked(subtask) { + if (subtask.nonWorking) return // console.log("task", task) - if (task.end.getTime() - task.start.getTime() <= 3600000) { + if (subtask.end.getTime() - subtask.start.getTime() <= 3600000) { // console.log("ShortTask") } }, @@ -212,12 +212,12 @@ export default { this.$events.emit('show-complete-task-modal', { subtask }) }, - editTask(task, editMode) { - this.$events.emit('show-task-modal', {task, editMode}) + editTask(subtask, editMode) { + this.$events.emit('show-subtask-modal', {subtask, editMode}) }, - deleteTask(task) { - this.$events.emit('show-delete-task-modal', {task}) + deleteTask(subtask) { + this.$events.emit('show-delete-task-modal', {subtask}) } } } diff --git a/app/src/plugins/tm@dashboard/projects/projects.vue b/app/src/plugins/tm@dashboard/projects/projects.vue index fd8c4ea..400d5af 100644 --- a/app/src/plugins/tm@dashboard/projects/projects.vue +++ b/app/src/plugins/tm@dashboard/projects/projects.vue @@ -81,7 +81,7 @@ export default { openMasterTaskModal(mastertaskId) { const mastertask = this.mastertasks.find(mastertask => mastertask.id == mastertaskId) - this.$events.emit('show-master-task-modal', {mastertask, editMode: false}) + this.$events.emit('show-mastertask-modal', {mastertask, editMode: false}) } } } diff --git a/app/src/plugins/tm@modal/blocker/z-blocker-modal.vue b/app/src/plugins/tm@modal/blocker/z-blocker-modal.vue index d5d7139..7882cf3 100644 --- a/app/src/plugins/tm@modal/blocker/z-blocker-modal.vue +++ b/app/src/plugins/tm@modal/blocker/z-blocker-modal.vue @@ -133,9 +133,10 @@ export default { }, methods: { - async showModal(blocker = null) { + async showModal({ blocker }) { this.visible = true this.blocker = null + this.$nextTick(() => this.v$.$reset()) try { const employees = await this.$axios.get_auth_data('v1/employees') diff --git a/app/src/plugins/tm@modal/master-task/_components/a-tasks-table.vue b/app/src/plugins/tm@modal/master-task/_components/a-tasks-table.vue index a3e15ee..3a0a45e 100644 --- a/app/src/plugins/tm@modal/master-task/_components/a-tasks-table.vue +++ b/app/src/plugins/tm@modal/master-task/_components/a-tasks-table.vue @@ -1,24 +1,24 @@