From 4baeac298157e3de9f1c153991a2d0c60592815b Mon Sep 17 00:00:00 2001
From: Michal Feher <feher@studiotem.com>
Date: Tue, 31 Jan 2023 08:58:22 +0100
Subject: [PATCH] TEAMS endpoint cleanup

---
 be/app/Http/Controllers/TeamController.php | 22 ++++++++++++++++++++++
 be/routes/api.php                          |  8 ++++----
 2 files changed, 26 insertions(+), 4 deletions(-)

diff --git a/be/app/Http/Controllers/TeamController.php b/be/app/Http/Controllers/TeamController.php
index 666a38b..4e59fb5 100644
--- a/be/app/Http/Controllers/TeamController.php
+++ b/be/app/Http/Controllers/TeamController.php
@@ -3,6 +3,7 @@
 namespace App\Http\Controllers;
 
 use App\Models\Team;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Validator;
 
@@ -19,6 +20,13 @@ class TeamController extends Controller
         $this->middleware('api');
     }
 
+    /**
+     * Create a new team
+     *
+     * @param Request $request
+     *
+     * @return JsonResponse
+     */
     public function store(Request $request)
     {
         $validator = Validator::make($request->all(), [
@@ -41,6 +49,13 @@ class TeamController extends Controller
         ], 201);
     }
 
+    /**
+     * Delete existing team
+     *
+     * @param Request $request
+     *
+     * @return JsonResponse
+     */
     public function delete(Request $request)
     {
         $validator = Validator::make($request->all(), [
@@ -61,6 +76,13 @@ class TeamController extends Controller
         ], 201);
     }
 
+    /**
+     * Update existing team
+     *
+     * @param Request $request
+     *
+     * @return JsonResponse
+     */
     public function update(Request $request)
     {
         $validator = Validator::make($request->all(), [
diff --git a/be/routes/api.php b/be/routes/api.php
index 653e70e..c1235c1 100644
--- a/be/routes/api.php
+++ b/be/routes/api.php
@@ -1,6 +1,7 @@
 <?php
 
 use App\Http\Controllers\TeamController;
+use App\Http\Controllers\UserController;
 use App\Http\Resources\MasterTaskCollection;
 use App\Http\Resources\MasterTaskResource;
 use App\Http\Resources\ProjectCollection;
@@ -32,18 +33,17 @@ use Illuminate\Support\Facades\Route;
 Route::get('/v1/teams', function () {
     return new TeamCollection(Team::all());
 });
+Route::get('/v1/teams/{id}', function ($id) {
+    return new TeamResource(Team::find($id));
+});
 Route::post('/v1/teams', TeamController::class . '@store');
 Route::delete('/v1/teams', TeamController::class . '@delete');
 Route::put('/v1/teams', TeamController::class . '@update');
 
-Route::get('/v1/teams/{id}', function ($id) {
-    return new TeamResource(Team::find($id));
-});
 
 Route::get('/v1/employees', function () {
     return new UserCollection(User::all());
 });
-
 Route::get('/v1/employees/{id}', function ($id) {
     return new UserResource(User::find($id));
 });