mirror of
https://bitbucket.org/studiotem/jandl-taskmanager-app.git
synced 2026-10-21 06:20:21 +00:00
refactor(SubTaskController): improve code formatting and consistency in validation and response handling
This commit is contained in:
1 parent
b101da8da5
commit
b7bad5f985
2 files changed
+13
-15
No files matched your search
@@ -1 +0,0 @@
|
|||||||
VUE_APP_WAXIOS_URL=http://127.0.0.1:8001/api/
|
|
||||||
@@ -116,7 +116,7 @@ class SubTaskController extends Controller
|
|||||||
->get();
|
->get();
|
||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'subtasks' => SubTaskResource::collection($subtasks)
|
'subtasks' => SubTaskResource::collection($subtasks),
|
||||||
], 200);
|
], 200);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -141,7 +141,7 @@ class SubTaskController extends Controller
|
|||||||
->get();
|
->get();
|
||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'subtasks' => SubTaskResource::collection($subtasks)
|
'subtasks' => SubTaskResource::collection($subtasks),
|
||||||
], 200);
|
], 200);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -162,7 +162,7 @@ class SubTaskController extends Controller
|
|||||||
}
|
}
|
||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'subtasks' => SubTaskResource::collection($query->get())
|
'subtasks' => SubTaskResource::collection($query->get()),
|
||||||
], 200);
|
], 200);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -231,7 +231,7 @@ class SubTaskController extends Controller
|
|||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'message' => 'Draft created successfully',
|
'message' => 'Draft created successfully',
|
||||||
'subtasks' => SubTaskResource::collection([$subtask])
|
'subtasks' => SubTaskResource::collection([$subtask]),
|
||||||
], 201);
|
], 201);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -278,7 +278,7 @@ class SubTaskController extends Controller
|
|||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'message' => 'Sub Task created successfully',
|
'message' => 'Sub Task created successfully',
|
||||||
'subtasks' => SubTaskResource::collection($subtasks)
|
'subtasks' => SubTaskResource::collection($subtasks),
|
||||||
], 201);
|
], 201);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -289,7 +289,7 @@ class SubTaskController extends Controller
|
|||||||
|
|
||||||
if (! $subtask) {
|
if (! $subtask) {
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'message' => 'Subtask not found.'
|
'message' => 'Subtask not found.',
|
||||||
], 404);
|
], 404);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -329,7 +329,7 @@ class SubTaskController extends Controller
|
|||||||
if ($publishValidator->fails()) {
|
if ($publishValidator->fails()) {
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'message' => 'Draft cannot be published. Missing required fields.',
|
'message' => 'Draft cannot be published. Missing required fields.',
|
||||||
'errors' => $publishValidator->errors()
|
'errors' => $publishValidator->errors(),
|
||||||
], 400);
|
], 400);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -400,7 +400,7 @@ class SubTaskController extends Controller
|
|||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'message' => $message,
|
'message' => $message,
|
||||||
'subtask' => new SubTaskResource($subtask)
|
'subtask' => new SubTaskResource($subtask),
|
||||||
]);
|
]);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -489,7 +489,7 @@ class SubTaskController extends Controller
|
|||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'message' => 'Draft published successfully',
|
'message' => 'Draft published successfully',
|
||||||
'subtasks' => SubTaskResource::collection($createdSubtasks)
|
'subtasks' => SubTaskResource::collection($createdSubtasks),
|
||||||
], 201);
|
], 201);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -512,7 +512,7 @@ class SubTaskController extends Controller
|
|||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'message' => 'Subtask deleted successfully.',
|
'message' => 'Subtask deleted successfully.',
|
||||||
'subtask' => $subtask
|
'subtask' => $subtask,
|
||||||
]);
|
]);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -543,14 +543,13 @@ class SubTaskController extends Controller
|
|||||||
'time' => $request->all()['data']['time'],
|
'time' => $request->all()['data']['time'],
|
||||||
'user_id' => $request->all()['data']['employee_id'],
|
'user_id' => $request->all()['data']['employee_id'],
|
||||||
'sub_task_id' => $subtask->id,
|
'sub_task_id' => $subtask->id,
|
||||||
"created_at" => Carbon::now(),
|
'created_at' => Carbon::now(),
|
||||||
"updated_at" => Carbon::now(),
|
'updated_at' => Carbon::now(),
|
||||||
]);
|
]);
|
||||||
|
|
||||||
return response()->json([
|
return response()->json([
|
||||||
'message' => 'Subtask timesheet submitted successfully.',
|
'message' => 'Subtask timesheet submitted successfully.',
|
||||||
'subtask' => $subtask
|
'subtask' => $subtask,
|
||||||
], 201);
|
], 201);
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
Reference in new issue
Block a user