From c72cb9fcdf366f9e065a829704f5375c7db25b00 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matej=20Glasn=C3=A1k?= <matej.glasnak@blume.sk>
Date: Thu, 8 Jan 2026 03:49:25 +0100
Subject: [PATCH] fix(z-task-modal): update validation rules for employee
 timeblock to ensure required fields are enforced correctly

---
 .../employees/a-employee-timeblock.vue        | 37 +++++++------------
 1 file changed, 14 insertions(+), 23 deletions(-)

diff --git a/app/src/plugins/tm@modal/task/_components/employees/a-employee-timeblock.vue b/app/src/plugins/tm@modal/task/_components/employees/a-employee-timeblock.vue
index 1397440..de18ea1 100644
--- a/app/src/plugins/tm@modal/task/_components/employees/a-employee-timeblock.vue
+++ b/app/src/plugins/tm@modal/task/_components/employees/a-employee-timeblock.vue
@@ -51,7 +51,7 @@
 <script setup lang="ts">
 import { computed, ref, watch, onMounted, nextTick } from 'vue';
 import { useVuelidate } from '@vuelidate/core';
-import { helpers } from '@vuelidate/validators';
+import { helpers, required } from '@vuelidate/validators';
 import { useEmployeeTimeline } from '@/plugins/tm@_utils/useEmployeeTimeline';
 import {
   timeblockToDateRange,
@@ -141,38 +141,29 @@ const timeRangeValid = (value: any, siblings: any) => {
 
 // Custom validator: field is required when start OR end time is filled
 // Uses siblings to check the current state of all fields
-const requiredWhenHasTime = (value: any, siblings: any) => {
-  // Check if timeblock has any TIME data (start or end time)
-  const hasStart = !!siblings.starts_at_time;
-  const hasEnd = !!siblings.ends_at_time;
-  const hasAnyTimeData = hasStart || hasEnd;
+// const requiredWhenHasTime = (value: any, siblings: any) => {
+//   // Check if timeblock has any TIME data (start or end time)
+//   const hasStart = !!siblings.starts_at_time;
+//   const hasEnd = !!siblings.ends_at_time;
+//   const hasAnyTimeData = hasStart || hasEnd;
 
-  // If no time data, no validation needed
-  if (!hasAnyTimeData) return true;
+//   // If no time data, no validation needed
+//   if (!hasAnyTimeData) return true;
 
-  // When time data exists, field must have value (not null, undefined, or empty string)
-  return value !== null && value !== undefined && value !== '';
-};
+//   // When time data exists, field must have value (not null, undefined, or empty string)
+//   return value !== null && value !== undefined && value !== '';
+// };
 
 // Vuelidate rules - if start OR end is filled, all three fields are required
 const rules = {
   date: {
-    requiredWhenHasTime: helpers.withMessage(
-      'Vyberte dátum',
-      requiredWhenHasTime,
-    ),
+    requiredWhenHasTime: helpers.withMessage('Vyberte dátum', required),
   },
   starts_at_time: {
-    requiredWhenHasTime: helpers.withMessage(
-      'Zadajte začiatok',
-      requiredWhenHasTime,
-    ),
+    requiredWhenHasTime: helpers.withMessage('Zadajte začiatok', required),
   },
   ends_at_time: {
-    requiredWhenHasTime: helpers.withMessage(
-      'Zadajte koniec',
-      requiredWhenHasTime,
-    ),
+    requiredWhenHasTime: helpers.withMessage('Zadajte koniec', required),
     timeRangeValid: helpers.withMessage(
       'Koniec musí byť po začiatku',
       timeRangeValid,